Skip to content

fix: send to not owner server warning message #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2024
Merged

fix: send to not owner server warning message #3111

merged 5 commits into from
Nov 4, 2024

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 24, 2024 •
edited
Loading

This PR fixes the issue where sending a universal RPC with a SendTo.NotOwner or SendTo.Owner attribute parameter would cause warnings to be logged about sending to the server when using a distributed authority network topology.

fix: #3086

Changelog

  • Fixed: Issue where NotOwnerRpcTarget or OwnerRpcTarget were not using their replacements NotAuthorityRpcTarget and AuthorityRpcTarget which would invoke a warning.

Testing and Documentation

  • Includes integration test updates (internal manual test).
  • Internal end-to-end test is slated to be added MPSNGM-520
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
1a11cec 
When sending to not owner, use the not authority target when using a distributed authority network topology.
@NoelStephensUnity
fix
d10a798 
When sending to owner, use the authority target when using a distributed authority network topology.
@NoelStephensUnity
update
c81d8ef 
adding change log entry
@NoelStephensUnity NoelStephensUnity changed the title Fix/send to not owner server error message fix: send to not owner server error message Oct 24, 2024
@NoelStephensUnity NoelStephensUnity changed the title fix: send to not owner server error message fix: send to not owner server warning message Oct 24, 2024
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/send-to-not-owner-server-error-…
5b1ba62 
…message
@NoelStephensUnity
fix
640af79 
This resolves the remaining issues with universal rpcs when using a distributed authority network topology.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 30, 2024 01:04
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 30, 2024 01:04
@NoelStephensUnity NoelStephensUnity merged commit d709df4 into develop-2.0.0 Nov 4, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/send-to-not-owner-server-error-message branch November 4, 2024 19:08
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity